Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Code Coverage CI #2556

Merged
merged 67 commits into from
Nov 15, 2023
Merged

Fixing Code Coverage CI #2556

merged 67 commits into from
Nov 15, 2023

Conversation

timbrinded
Copy link
Contributor

What does it do?

Fixes the code coverage CI

What value does it bring to the blockchain users?

Reduces CI noise so more timely blockchain monitoring

@timbrinded timbrinded added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Coverage Report

@@                  Coverage Diff                   @@
##           master   timbo-fix-coverage      +/-   ##
======================================================
+ Coverage   80.23%               80.91%   +0.68%     
- Files         287                  286       -1     
+ Lines       95229                95240      +11     
======================================================
+ Hits        76398                77058     +660     
- Misses      18831                18182     -649
Files Changed Coverage
/node/cli/src/cli.rs 29.49% (+29.49%) 🔼
/node/cli/src/command.rs 10.97% (+10.97%) 🔼
/node/cli-opt/src/account_key.rs 32.79% (+1.64%) 🔼
/node/cli-opt/src/lib.rs 24.00% (+24.00%) 🔼
/node/service/src/chain_spec/mod.rs 89.66% (+29.32%) 🔼
/node/service/src/chain_spec/moonbase.rs 75.36% (+65.22%) 🔼
/node/service/src/lib.rs 34.11% (+12.65%) 🔼
/node/src/main.rs 100.00% (+100.00%) 🔼
/pallets/proxy-genesis-companion/src/lib.rs 81.82% (+22.73%) 🔼
/precompiles/gmp/src/lib.rs 15.94% (-0.90%) 🔽
/precompiles/utils/src/precompile_set.rs 77.72% (+4.80%) 🔼
/primitives/ext/src/lib.rs 48.28% (+3.45%) 🔼
/runtime/common/src/migrations.rs 85.43% (+85.43%) 🔼
/runtime/moonbase/src/lib.rs 50.51% (+1.67%) 🔼
/runtime/moonbeam/src/lib.rs 68.97% (-0.17%) 🔽
/runtime/moonriver/src/lib.rs 69.47% (-0.18%) 🔽

Coverage generated Wed Nov 15 11:00:56 UTC 2023

@timbrinded timbrinded marked this pull request as ready for review November 15, 2023 13:14
@timbrinded
Copy link
Contributor Author

Important

Failing CI here (chopsticks) is unrelated to this PR and is another issue related to chopsticks/moonriver and will be tackled separately.

@timbrinded timbrinded merged commit ece2cce into master Nov 15, 2023
@timbrinded timbrinded deleted the timbo-fix-coverage branch November 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noandrea noandrea noandrea approved these changes

@librelois librelois Awaiting requested review from librelois

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timbrinded @noandrea